Attention is currently required from: osmith.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 12: ./gtp-link add gtp0 ip # IPv4 GGSN

    It would be great that while doing this we take into account that we will want to specify an outer IPv4/IPv6 address instead of currently used ANY_ADDR.

  • Patch Set #1, Line 15: ./gtp-link add gtp0 ip6 --sgsn # IPv6 SGSN

    Also, afaiu it should be possible to have one tunnel bind to both an IPv4 and an IPv6 address, and depending on the IP address provided by the peer, use one or another when sharing messages.
    (see GTPv1C/GTPv2C where it's possible to signal both an IPv4 and IPv6 address to the peer).

• File tools/gtp-link.c:

  • Patch Set #1, Line 159: ret = gtp_dev_create(-1, argv[2], gtp_sock.fd1, gtp_sock.fd2);

    I'd welcome if we could rename this fd1 and fd2 to fd0 and fd1u to name which proto are they used for (no need to do it in this same patch).

To view, visit change 35985. To unsubscribe, or for help writing mail filters, visit settings.