Attention is currently required from: pespin.
1 comment:
File src/gsm/gsm48_ie.c:
Patch Set #1, Line 140: * \param[in] max_len Maximum value of the L octet; \a bcd_lv must have
MY understanding is that you are basically changing the meaning of this parameter here, and hence ch […]
I agree. I've reworked the patch locally: max_len stays the size of bcd_lv, the callers are back to passing sizeof(), and the check now accounts for the L octet.
There is one thing I wanted to note:
Osmo-sgsn sgsn_libgtp.c passes max_len=8 for the 16-digit IMEISV, which needs 9 bytes. That relies on the current L <= max_len check, and the return code is ignored, so with the stricter check it would silently send an all-zero IMEISV.
I have created a patch for this here: https://gerrit.osmocom.org/c/osmo-sgsn/+/44150
So if you agree, I think the right move should be first to review osmo-sgsn patch and upload new patch set here? Or would you prefer to look at them both at same time?
To view, visit change 44142. To unsubscribe, or for help writing mail filters, visit settings.