Attention is currently required from: pespin.

View Change

4 comments:

• File libosmo-trx/src/trx_ep.c:

  • Patch Set #2, Line 245: if (res > 0 && osmo_iofd_txqueue_len(iofd) > 0)

    in io_uring backend, with asynchronous write operations, the fact that the userspace iofd txqueue is […]

    Acknowledged

  • Patch Set #2, Line 269: talloc_steal(OTC_GLOBAL, iofd);

    This patch is set Work-in-Progress and I never marked this thread as resolved, so no surprise here.

    Done

• File libosmo-trx/src/trx_ep.c:

  • Patch Set #4, Line 285: if (res > 0 && flush->wr_completed < flush->wr_offset)

    FIXME: take into account variable wrap around (feel free to submit to osmo-pcap too ;).

    I've changed the logic to use a single counter instead. It gets incremented when `osmo_iofd_write_msgb()` is called, and decremented in `trx_ep_ctrl_write_cb()`/`trx_ep_ctrl_flush_write_cb()`. This way, and given the low volumes of TRXC traffic, a wrap around is unlikely to happen.

  • Patch Set #4, Line 305: if (chan->ctrl_wr_completed >= chan->ctrl_wr_offset) {

    FIXME: take into account variable wrap around (feel free to submit to osmo-pcap too ;).

    See my other comment.

To view, visit change 43112. To unsubscribe, or for help writing mail filters, visit settings.