Attention is currently required from: neels, pespin, fixeria.
Patch set 1:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #1:
+1 Given that this breaks apply-config-file, this is a bug.
I do understand how fixeria described that it would be useful during initial config file parsing to avoid unintentional mistakes. Maybe one idea would be (for a future patch) to complain about it only during startup, and possibly add a cli argument to ignore it.
To view, visit change 29551. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e70d20d48a28c46a21dd10358577e5c798744c
Gerrit-Change-Number: 29551
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Oct 2022 13:54:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment