Attention is currently required from: neels, fixeria, dexter.

View Change

2 comments:

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #17, Line 280: uint8_t pgroup[3];

    I think we should transfer the whole IMSI to osmo-bsc. […]

    Send whole IMSI to BTS/BSC: fine let's to that.

• File src/bts.cpp:

  • Patch Set #17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));

    It seems that the discussion is a bit stuck here. I suggest the following compromise: […]

    Agree with the first part: Add the new message sending the whole IMSi and keep the backward compatibility in this patch and we will also bump the version number

    Disagree with the second part: The fact that we still support the older version of the protocol with the older version of the message in osmo-pcu doesn't mean we need to bump the version again to drop the old message. From protocol point of view, the old message doesn't exist anymore after the first bump. It's just an implementation thing of osmo-pcu to keep supporting the older version of the protocol which still uses the old message.
    Moreover, let's keep this backward compatibility (allow use of older protocol version) for a while to let osmo-pcu work with older osmo-bts for a while.

To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.