Attention is currently required from: fixeria, laforge.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I agree that conceptually it is "mixing layers". […]

    To me its clear given the combination matrix above that it makes no sense to create a type for each of those permutations.
    Futhermore, following the same rule of thumb we'd also have yet another axis where one would have "tcp-client" and another "tcp-server", and "sctp-client", and "sctp-server". All of that makes no sense, it's clearly trying to put together stuff from different layers, which we already keep properly separated by the "role asp|sg" and "sctp-role client|server".

    I'd really go for adding a "transport tcp|sctp" and be done with. Most of the code can be kept the same and we only need to patch sections really doing stuff with lower layers.

To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.