Attention is currently required from: fixeria, pespin.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I am wondering if we can use `Misc_Helpers.f_shutdown` instead? It's used once in this file.

    Reading `Misc_Helpers.f_shutdown`, it will evaluate to the same `setverdict(fail, …)` and `mtc.stop`, except that it also prints this log line: `log("Stopping testcase execution from ", file, ":", line)`.

    So yes we can use it instead, but personally I don't think the extra log line is that useful and I think the separate `setverdict`and `mtc.stop` lines look more elegant than this long line: `Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "…");`. Also the separate `setverdict` + `mtc.stop` lines are already used a lot throughout the file. So I'd prefer to keep the patch as-is.

To view, visit change 33630. To unsubscribe, or for help writing mail filters, visit settings.