View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: csd_bs: cosmetic changes to csd_bs_list_to_bearer_cap()
It does not change the way this function behaves though. […]
You are doing at least 2 changes which change the logic and potentially change the instruction set on the output binary:
- Allocating a var in the stack every loop iteration
- Marking the variable as const
So it's not really about changing a typo in a comment or changing the name of a variable.
To view, visit change 38510. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I101f55dfbd0d327269fcce76031a2db265ca2eb9
Gerrit-Change-Number: 38510
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Oct 2024 13:31:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>