Attention is currently required from: arehbein, pespin.
Patch set 2:Code-Review +2
View Change
1 comment:
Patchset:
Patch Set #2:
I'm in favor of logging 'local' and 'remote' instead of just 'l' and 'r', but I suppose that's a mat […]
i prefer explicit, but there is a practical limiting factor: log lines i produce tend to be overly long. particularly in wireshark that can make gsmtap_log very hard to read (has a length limit on the info column). So especially when we say "local" and "remote" for four GTP addrs, four TEIDs, and two SEIDs in one log line, that's where "l" and "r" has to be enough...
To view, visit change 30459. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ic539ebe84a0853f665e5b8b8489dd587e6907287
Gerrit-Change-Number: 30459
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: arehbein <arehbein@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 09 Dec 2022 17:18:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: arehbein <arehbein@sysmocom.de>
Gerrit-MessageType: comment