Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith.

Patch set 25:Code-Review -1

View Change

4 comments:

• Patchset:

  • Patch Set #25:

    Now that the build part is solved, I looked a bit more in detail at the C logic and found some flaws, please fix the comments and resubmit.

• File src/core/logging_emscripten.c:

  • Patch Set #25, Line 44: const int msgLen = 4096;

    Use MAX_LOG_SIZE from ./include/osmocom/core/logging_internal.h instead.

  • Patch Set #25, Line 47: char subsys_buf[16];

    why is this 16 bytes?

  • Patch Set #25, Line 57: if (msg[rc - 1] == '\n') msg[rc - 1] = '\0';

    man vsnprintf:

        If the output was truncated due to this limit, then the return value is the number of characters (excluding the terminating null byte) which would have been written to the final string if  enough  space
           had been available.
           
    You may be writing out of "msg" here if the input string is more than 4096 chars.

To view, visit change 41813. To unsubscribe, or for help writing mail filters, visit settings.