Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo_ss7_combined_linkset.c:

  • Patch Set #1, Line 215: struct osmo_ss7_route *rt_found = NULL;

    maybe shorten it as follows, without using rt_found?

    ```c
    static struct osmo_ss7_route *ss7_combined_linkset_assign_route_roundrobin(struct osmo_ss7_combined_linkset *clset)
    {
    	struct osmo_ss7_route *rt = NULL;
    	unsigned int i;
    	for (i = 0; i < clset->num_routes; i++) {
    		rt = ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin_ass, struct osmo_ss7_route, list);
    		if (rt)
    			break;
    	}
    	return rt;
    }
    ```

To view, visit change 39708. To unsubscribe, or for help writing mail filters, visit settings.