Attention is currently required from: pespin. 
View Change
1 comment:
File tests/stubs.c:
Patch Set #1, Line 42: char *osmo_stream_srv_link_get_sockname(const struct osmo_stream_srv_link *link) { return NULL; }
not sure if returning NULL instead of "" here may be an issue?
It hadn't so far. If it ever does than we could change either stub or the test depending on the view of defensive programming.
To view, visit change 28842. To unsubscribe, or for help writing mail filters, visit settings.
 Gerrit-Project: osmo-msc 
 Gerrit-Branch: master 
 Gerrit-Change-Id: Ic854eb919e6fcc82bd0245f62c72985b938c6b7a 
 Gerrit-Change-Number: 28842 
 Gerrit-PatchSet: 3 
 Gerrit-Owner: msuraev <msuraev@sysmocom.de> 
 Gerrit-Reviewer: Jenkins Builder 
 Gerrit-Reviewer: pespin <pespin@sysmocom.de> 
 Gerrit-Attention: pespin <pespin@sysmocom.de> 
 Gerrit-Comment-Date: Sat, 30 Jul 2022 08:01:23 +0000 
 Gerrit-HasComments: Yes 
 Gerrit-Has-Labels: No 
 Comment-In-Reply-To: pespin <pespin@sysmocom.de> 
 Gerrit-MessageType: comment