25 comments:
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1222: if (req.mi.type == GSM_MI_TYPE_IMSI) {
braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1292: if (!mmctx->attach_rau.rau_fsm || rc != 0) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1553: else {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1557: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1675: if (!foreign_ra &&
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1761: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1789: if (mmctx) {
braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1819: if (!mmctx->attach_rau.rau_fsm || rc != 0) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 1967: } else {
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2365: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2380: case VLR_INVAL_REASON_UPDATE_LOCATION:
trailing whitespace
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2414: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */
'loosing' may be misspelled - perhaps 'losing'?
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2441: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI)
that open brace { should be on the previous line
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2456: if (ctx->attach_rau.rau_fsm) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2462: switch(ctx->ran_type) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 2500: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) {
braces {} are not necessary for single statement blocks
File src/sgsn/gprs_rau_fsm.c:
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 206: switch(mmctx->ran_type) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 231: switch(mmctx->ran_type) {
space required before the open parenthesis '('
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL),
need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL),
need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init()
Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void)
File src/sgsn/mmctx.c:
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 662: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) {
braces {} are not necessary for single statement blocks
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 533: if (cause != GTPCAUSE_NON_EXIST) {
braces {} are not necessary for single statement blocks
File src/sgsn/sgsn_main.c:
Robot Comment from checkpatch (run ID ):
Patch Set #8, Line 360: [DVLR] = {
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ):
please, no spaces at the start of a line
To view, visit change 39562. To unsubscribe, or for help writing mail filters, visit settings.