Attention is currently required from: lynxis lazus, pespin.
1 comment:
Patchset:
Does that imply your patches get higher preference than mine? because it has been clarified that testing is not a real reason comapring to your patches.
I am really not liking this tone and direction of the conversation. I never said or implied that. After all, you were the one who gave CR+2 on the whole patchset, so I merged it a few days after getting the necessary CR+3. Testing coverage was WIP at that time. It's not like I was playing a race trying to get those patches merged earlier than yours.
It has also been about a week ago when I wrote this comment:
Let's keep this patch in review until we have functional or at least unit tests.
which was not acted/commented upon, and you're now blaming me for keeping your patches trapped.
You could have merged mine and worked on top of mine, like I usually do with yours, because I consider this helps everybody.
I don't remember this being discussed and negotiated in advance. I am also surprised to hear this, because I didn't touch the proxy module (only the `pfcp_peer`), so how could have this created conflicts with this patch? It might have created conflicts for the metrics patch, which was submitted exactly in the same day I submitted my patches adding the heartbear procedure... I am puzzled.
To view, visit change 37924. To unsubscribe, or for help writing mail filters, visit settings.