pespin has uploaded this change for review.
lchan: Reset Abis RTP/Osmux config during lchan release
Otherwise some shared variables used by both Osmux and RTP was left set,
like connect_ip and connect_port, and next time the lchan was selected,
those were already configured even if they didn't come in IPAC CRCX.
This is specially bad if the channel was reused to set up an Osmux call,
since the osmux code path relied on those fields being properly reset
until set by IPAC CRCX.
Change-Id: I414bd0bc801451357bb45b89197a95e51b7c97f1
---
M src/common/lchan.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/29425/1
diff --git a/src/common/lchan.c b/src/common/lchan.c
index 892d9b7..0402c17 100644
--- a/src/common/lchan.c
+++ b/src/common/lchan.c
@@ -207,6 +207,8 @@
} else if (lchan->abis_ip.osmux.use) {
lchan_osmux_release(lchan);
}
+ /* reset all Abis related config: */
+ memset(&lchan->abis_ip, 0, sizeof(lchan->abis_ip));
/* FIXME: right now we allow creating the rtp_socket even if chan is not
* activated... Once we check for that, we can move this check at the
To view, visit change 29425. To unsubscribe, or for help writing mail filters, visit settings.