dexter submitted this change.

View Change

pcu_sock: fix memleak

pcu_sock_read() may not free the message buffer in case the recv
returned errno EAGAIN. This is already fixed in osmo-bts, lets fix it in
osmo-bsc as well.

Related: OS#5198
Change-Id: I49eda447fc1912c1f7f25ba07331cb84decf4548
---
M src/osmo-bsc/pcu_sock.c
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c
index 45ff835..2cf1ab5 100644
--- a/src/osmo-bsc/pcu_sock.c
+++ b/src/osmo-bsc/pcu_sock.c
@@ -567,8 +567,10 @@
 		goto close;
 
 	if (rc < 0) {
-		if (errno == EAGAIN)
+		if (errno == EAGAIN) {
+			msgb_free(msg);
 			return 0;
+		}
 		goto close;
 	}
 

To view, visit change 29360. To unsubscribe, or for help writing mail filters, visit settings.