Attention is currently required from: neels, fixeria.

View Change

1 comment:

• File include/osmocom/gsm/gsm0502.h:

  • Patch Set #1, Line 36: #define GSM_NBITS_NB_GMSK_PAYLOAD 2 * 58

    > I think shitfting operations take precedence over multiplication? […]

    ok, still if you use this after a division you'll have problems:
    45 / GSM_NBITS_NB_GMSK_PAYLOAD = 45 / 2 * 58 = 22 * 58
    but in this case you'd actually want 45 / (2 * 58) = 45 / 116

    But tbh, simply don't care about details and put parenthesis as a rule of thumb.

To view, visit change 31669. To unsubscribe, or for help writing mail filters, visit settings.