Attention is currently required from: laforge, pespin.

View Change

4 comments:

• File include/s1gw_metrics.hrl:

  • Patch Set #8, Line 40: %% NOTE: these counters shall not be listed in ?S1GW_COUNTERS,

    It's fine having a comment, just though the comment there kind of created an alamr in my head (as in […]

    Done

• File rebar.config:

  • Patch Set #8, Line 13: {git, "https://gitea.osmocom.org/vyanitskiy/enftables.git", {branch, "fixeria/json"}}},

    Done

    https://gitea.osmocom.org/erlang/enftables

• File src/enft_kpi.erl:

  • Patch Set #8, Line 142: R1 = [nft_expr_match_ip_proto("udp", ?OP_NEQ), nft_expr_accept()],

    Acknowledged

    https://gitea.osmocom.org/erlang/enftables/commit/63b0d9ebc2db8bda72bce8a9baf82ef938304a58
    https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40439

  • Patch Set #8, Line 341: case enb_add_nft_counters(ES0#{addr => Addr}, Cfg) of

    Be careful though because that may need some work/complexity as it becomes async. […]

    Done

To view, visit change 40281. To unsubscribe, or for help writing mail filters, visit settings.