Attention is currently required from: pespin.

View Change

1 comment:

• File src/trau/trau_rtp_conv.c:

  • Patch Set #1, Line 671: if (data[0] & 0xD0)

    Having a bitmask of defines here would be a lot clearer.

    The objective is to accept 0x00 or 0x20 and no others in the upper nibble, while accepting anything in the lower nibble. Masking with 0xD0 is the most efficient way to implement this check. In terms of the "bitmask of defines" you are asking for, can you please elaborate? Exactly how do you propose I change this code?

To view, visit change 39626. To unsubscribe, or for help writing mail filters, visit settings.