Attention is currently required from: fixeria, jolly.
View Change
1 comment:
File src/ss7_asp_peer.c:
Patch Set #2, Line 68: peer->host[0]
Done
Please note
osmo_multiaddr_ip_and_port_snprintf() (the func I took as a reference) expects an array of buffers, not an array of pointers to buffers, hence why the NULL case isn't checked there.
To view, visit change 43753. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: jolly <andreas@eversberg.eu>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Oct 2026 11:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas@eversberg.eu>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>