Attention is currently required from: laforge, pespin, msuraev.

View Change

5 comments:

• File include/osmocom/hnbgw/context_map.h:

  • Patch Set #6, Line 18: * - For events that may send a RANAP message towards CN via SCCP, the msgb shall have reserved headrom to fit a struct

    typo: headroom

    lol head-ROM =)

• File src/osmo-hnbgw/context_map_rua.c:

  • Patch Set #6, Line 57: * Assumes local variable fi exists. */

    That's very confusing - better make no assumptions and pass all variables explicitly. […]

    I agree with the principle but this one is the exception; 'fi' is literally everywhere in an fsm implementation .c file. We use a macro like this in pretty much all osmo_fsm implementation .c files.

• File src/osmo-hnbgw/context_map_sccp.c:

  • Patch Set #6, Line 63: * Assumes local variable fi exists. */

    Same here.

    Done

• File src/osmo-hnbgw/hnbgw.c:

  • Patch Set #6, Line 862: ranap_msg = msgb_alloc_c(OTC_SELECT, sizeof(struct osmo_scu_prim) + 1500, name);

    Where does 1500 comes from?

    that's a good question, I took it from prior code. Actually, before, osmo-hnbgw would reserve 1500 in *total*, and would even subtract from that the headroom required for osmo_scu_prim; so apparently all RANAP messages that osmo-hnbgw processed so far are way shorter than that.
    Maybe it comes from the common MTU = 1500?

• File src/osmo-hnbgw/hnbgw_rua.c:

  • Patch Set #6, Line 230: msg = msgb_alloc(1500, "rua_to_sccp");

    (this is where I took 1500 from; note that it first puts the prim, and then the ranap in l2h below)

To view, visit change 31431. To unsubscribe, or for help writing mail filters, visit settings.