Attention is currently required from: fixeria, osmith.

View Change

1 comment:

• File src/sccp2sua.c:

  • Patch Set #2, Line 1449: sccp_longdata_to_sua_ptr(xua, SUA_IEI_DATA, (uint8_t *)&ludt->variable_data);

    there's probably a reason, but to be sure: why not run sccp_longptr_part_consistent again here, and […]

    You mean for the optional? part? because the DATA part is being checked above it.
    For the optional part, simply because I'm following the exact same pattern as existing UDT and XUDT, so in any case it would have to be fixed/improved in all places.
    I can have a look after having this patch merged, since it's the one being required right now (and proven to work).

To view, visit change 34467. To unsubscribe, or for help writing mail filters, visit settings.