Attention is currently required from: neels, fixeria.
View Change
1 comment:
File src/sccp_scoc.c:
Patch Set #12, Line 459: osmo_sccp_conn_id_exists
My suggestion is to expose conn_find_by_id() and use it to check connection existence, instead of ad […]
I don't see any advantage in doing that: even if we expose that function it would still be more convenient to write the wrapper returning bool.
To view, visit change 29087. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01
Gerrit-Change-Number: 29087
Gerrit-PatchSet: 13
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Aug 2022 12:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev@sysmocom.de>
Gerrit-MessageType: comment