Attention is currently required from: pespin.

View Change

1 comment:

• File src/common/nm_bb_transc_fsm.c:

  • Patch Set #2, Line 139: SITE_MGR

    as per TS 12.21 there may not be, but extensions can still be added.

    IMO, adding dead code with hypothetical applicability (maybe in the future, maybe not) is not a good idea. One can always add this whenever needed. Your comment in the code "osmo-bsc doesn't send SetAttr" makes it even more confusing, as if osmo-bsc (or any other BSC) is expected to do so but does not for some reason.

    Unless you're actually planning to implement any extensions, please either remove this block of code or at least make the comment less confusing, e.g. "no attributes defined in section 6.5" or so.

To view, visit change 32212. To unsubscribe, or for help writing mail filters, visit settings.