Attention is currently required from: fixeria, laforge.

View Change

6 comments:

• File src/sgsn/gprs_gmm_util.c:

  • Patch Set #3, Line 93: l3 pointers must point to gmm

    what does this even mean...

    l3 pointer of msgb must point to the (start of) GMM

  • Patch Set #3, Line 94: rau_req

    (copy-paste) `rau_req` -> `att_req`

    Acknowledged

  • Patch Set #3, Line 97: struct msgb *msg

    `const`? you're not modifying it, right?

    Done

  • Patch Set #3, Line 119: 21

    where this magic number is coming from? do we have a define for it?

    The problem here are the dynamic, but mandatory, IEs in form of LV in GMM.
    But there are multiple dynamic LV IEs in the Attach Req.
    So the GMM Attach Req can't be smaller then 25 bytes.
    After MS Network Capability come at least 21 bytes.

  • Patch Set #3, Line 122: if (len == 0)

    "must be at least 2 bytes long" suggests `len < 2`?

    Done

  • Patch Set #3, Line 143: 12

    likewise

    See the mention upwards. I wouldn't use a define for a value here.

To view, visit change 39246. To unsubscribe, or for help writing mail filters, visit settings.