Attention is currently required from: fixeria.

View Change

2 comments:

• File pySim/esim/saip/templates.py:

  • Patch Set #1, Line 23: __init__

    cosmetic: too many params, may of which are optional. I would go for `**kw` here: […]

    i prefer if i can see the parameters in the method declaration and don't have to read through the body to see what kind of arguments are supported by a given method.

  • Patch Set #1, Line 531: FilesUsimDf5GSv2

    duplicate definition

    yeah, actually the first definition above is the culprit, it should be FilesUsimDf5GS and this one remains v2.

To view, visit change 35731. To unsubscribe, or for help writing mail filters, visit settings.