Attention is currently required from: dexter, laforge, neels.

View Change

4 comments:

• File src/libosmo-mgcp-client/mgcp_client.c:

  • Patch Set #3, Line 1317: ip

    it's the other way around, this function should not be freeing msg, it's freed by the caller.

    Done

  • Patch Set #3, Line 1323: urn -

    I mean: not return -EINVAL, instead skip the PRINTF("c=IN"). […]

    What you are proposing is imho even more complex to understand and handle, and changing the existing behavior.

    The current approach is simple and expectable imho: If the caller has an IP address and wants to share it, it will set the appropriate existing flag to say so. If the code filling in the mgcp message finds out it needs to fill in the address but it finds it cannot, then it returns an error to the caller because clearly something is unexpected and wrong at the caller.

  • Patch Set #3, Line 1367: *

    Ack

    Done

  • Patch Set #3, Line 1373: *

    Ack

    Done

To view, visit change 35152. To unsubscribe, or for help writing mail filters, visit settings.