Attention is currently required from: jolly.
3 comments:
File include/osmocom/isdn/lapd_core.h:
Patch Set #5, Line 155: unsigned
you are modifying a public data structure, which is ABI breakage. Old applications must not link against new lib and vice-versa. This must be documented in TODO-RELEASE as it requires a libversion bump.
File src/isdn/lapd_core.c:
handle how? This requires more ddocumentation. I know the original code is not very good in terms of doxygen aPI documentation, but new functions could start with it right away.
The library API must document how it is used by an application program.
Patch Set #5, Line 399: dl->flags = flags;
I guess it would leads to undefined behaviour if somebody called lapd_dl_set_flags to enable RTS mode at a random *later* time after already having started to use the non-RTS mode. We should protect against this here. I guess the RTS flag should only be modifiable during an initial state before any timers are started?
To view, visit change 34985. To unsubscribe, or for help writing mail filters, visit settings.