lynxis lazus submitted this change.

View Change

Approvals: neels: Looks good to me, approved Jenkins Builder: Verified
SGSN_Tests_NS: NS related tests: use the shutdown helper

Currently the test case TC_SNS_config_sgsn() is failing because of a
dynamic test error after succeeding. Use the Misc_Helpers.f_shutdown()
to prevent this.

Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f
---
M sgsn/SGSN_Tests_NS.ttcn
1 file changed, 8 insertions(+), 0 deletions(-)

diff --git a/sgsn/SGSN_Tests_NS.ttcn b/sgsn/SGSN_Tests_NS.ttcn
index e5d012f..ed21d5f 100644
--- a/sgsn/SGSN_Tests_NS.ttcn
+++ b/sgsn/SGSN_Tests_NS.ttcn
@@ -13,6 +13,7 @@
import from Osmocom_Types all;
import from Osmocom_Gb_Types all;
import from Osmocom_VTY_Functions all;
+import from Misc_Helpers all;
import from NS_Types all;
import from RAW_NS all;
import from SGSN_Tests all;
@@ -29,6 +30,7 @@

f_sleep(1.0);
f_clean_ns_codec();
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

testcase TC_NS_connect_alive() runs on RAW_Test_CT {
@@ -45,6 +47,7 @@

f_sleep(1.0);
f_clean_ns_codec();
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

/* perform outgoing SNS-SIZE procedure */
@@ -55,6 +58,7 @@

f_outgoing_sns_size();
setverdict(pass);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

/* outgoing SNS-SIZE procedure with more BSS side IPs than SGSN can handle */
@@ -65,6 +69,7 @@

f_outgoing_sns_size(cause := NS_CAUSE_INVALID_NR_OF_NSVCS, num_ip := 100);
setverdict(pass);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

/* perform outgoing SNS-CONFIG procedure (for BSS) */
@@ -76,6 +81,7 @@
f_outgoing_sns_size();
f_outgoing_sns_config();
setverdict(pass);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

/* perform incoming SNS-CONFIG procedure (for SGSN) */
@@ -88,6 +94,7 @@
f_outgoing_sns_config();
f_incoming_sns_config();
setverdict(pass);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

/* perform full SNS handshake and then outbound NS-ALIVE */
@@ -101,6 +108,7 @@
f_incoming_sns_config();
f_outgoing_ns_alive();
setverdict(pass);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}

control {

To view, visit change 37812. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I08eee0d11ae04276ca1ad8fd58ebb93dd6d0066f
Gerrit-Change-Number: 37812
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>