Attention is currently required from: fixeria, laforge.

6 comments:

File pySim/global_platform/__init__.py:
- Patch Set #7, Line 20: import io
  unused import? […]
  I think you overlooked it. It is used in do_load
- Patch Set #7, Line 772: Prefixed(Int8ub, GreedyBytes
  This is basically LV structure. […]
  I have tried out what happens when I use LV, but it does not work. LV is indeed different. We use the /HexAdapter(Prefixed(Int8ub, GreedyBytes) in various other places too. I would suggest to keep it like it is.
- Patch Set #7, Line 824: ('--from-hex
  why not using `type=is_hexstr` here?
  Done
- Patch Set #7, Line 824:
```
        load_parser.add_argument('--from-hex', help='load from hex string')
        load_parser.add_argument('--from-file', help='load from binary file')
  
```
  If these params are mutually-exclusive (only one of these must be supplied), please create a group u […]
  Done
- Patch Set #7, Line 833:
  formatting
  Interesting that I got no errors, python3 is normally very picky about this.
- Patch Set #7, Line 835: with open(opts.from_file, 'rb') as f:
  BTW, argparse does have: https://docs.python.org/3/library/argparse. […]
  Done

To view, visit change 37454. To unsubscribe, or for help writing mail filters, visit settings.