Attention is currently required from: dexter, laforge, neels, osmith.
hampushellsberg uploaded patch set #4 to the change originally created by laforge.
The following approvals got outdated and were removed: Code-Review+1 by dexter, Verified+1 by Jenkins Builder
personalization: SmspTpScAddr edits record 1 of EF.SMSP only
SmspTpScAddr decoded the whole EF.SMSP body as record 1 and wrote one
encoded record back as the whole body. EF.SMSP is linear fixed and a
profile can declare more than one record: both TS.48 v5 profiles in
smdpp-data/upp carry a fileDescriptor with record length 42 and no
record count, and efFileSize 84, so two records. While pySim takes the
record count from the template (one record) this goes unnoticed; once
the count follows efFileSize, the body holds both records, decoding all
84 bytes as one record fails on the alpha identifier, and
test_configurable_parameters fails.
Decode and encode record 1 only, and keep the records after it.
The folder osmocom-pysim-saip-record-count of
hampushellsberg-dev/PySIM-upstream-patches on GitHub carries this patch
next to the record count fix that needs it.
Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1
---
M pySim/esim/saip/personalization.py
M tests/unittests/test_configurable_parameters.py
2 files changed, 29 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/43983/4
To view, visit change 43983. To unsubscribe, or for help writing mail filters, visit settings.