Attention is currently required from: fixeria, laforge, neels, osmith.
Patch set 1:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #1:
well, actually after some more thought, option 2 sounds like it causes less problems for users, so l […]
I am currently using pySim-shell with 2.5.0, no issues to far. I bet 2.6.2 will also work well. I think that raising the version requirements would be good because we could get rid of backward compatibility workarounds (e.g. the colors in pySim-shell.py). But I also see the point that there might be users out there that are still bound to cmd2 1.5 for some reason.
To view, visit change 41642. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I71cee0ec3ed2abec68ec567beaab13c868721dad
Gerrit-Change-Number: 41642
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Dec 2025 15:15:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>