Attention is currently required from: osmith.
View Change
1 comment:
File src/gsm/gsm23236.c:
Patch Set #1, Line 490: struct osmo_nri_range add_range = {};
Then I see no problem? everything is as expected?
Coverity is basically unhappy because at line 497 we're copying a struct with partly-initialized fields. This can be easily solved by moving it below the check at line 499, as you suggested.
To view, visit change 33400. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icaf53fda8752e9d2bd2cfe8c7b89bb31b90f684f
Gerrit-Change-Number: 33400
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Jun 2023 11:47:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment