Attention is currently required from: Timur Davydov.

View Change

2 comments:

• File Transceiver52M/device/websdr/TransceiverWebSdr.cpp:

  • Patch Set #3, Line 50: : Transceiver(cfg, wTransmitLatency, wRadioInterface)

    I'm not really liking the patch. You are mixing tons of stuff in the same patch and changing/maningling the whole architecture of the file structure.
    device backends under Transcevier52/device/ are expected to have mostly only implementations/subclasses of radioDevice, not whole reimplementations of Transceiver, etc.
    Something is wrong here.

• File Transceiver52M/device/websdr/osmo-trx-websdr.cpp:

  • Patch Set #3, Line 151: g_trx_ctx->cfg.filler = FILLER_DUMMY;

    check indentation here and below.

To view, visit change 42411. To unsubscribe, or for help writing mail filters, visit settings.