osmith submitted this change.
abis_nm_ipaccess_rsl_connect: initialize ia
Fix access to uninitialized value from inet_ntoa(ia) inside the log
message, found with valgrind.
Change-Id: I6c04fdc329bb56b82087c817e2fbe5a6504bf1dc
---
M src/osmo-bsc/abis_nm.c
1 file changed, 2 insertions(+), 0 deletions(-)
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index a4976c0..62f62b6 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -3051,6 +3051,8 @@
if (ip != 0) {
ia.s_addr = htonl(ip);
msgb_tv_fixed_put(attr, NM_ATT_IPACC_DST_IP, 4, (void*)&ia.s_addr);
+ } else {
+ ia = (struct in_addr){};
}
LOG_TRX(trx, DNM, LOGL_INFO, "IPA RSL CONNECT IP=%s PORT=%u STREAM=0x%02x\n",
To view, visit change 27951. To unsubscribe, or for help writing mail filters, visit settings.