Attention is currently required from: fixeria, laforge, osmith.
Patch set 4:Verified +1Code-Review +2
4 comments:
Patchset:
I have now looked at this again. I think the code is 100% correct now. I also re-tested the applet installation and it still works. I think we can merge this now.
File pySim/global_platform/install_param.py:
this looks correct, but I would add some comments to make the code easier to understand: […]
Done
Patch Set #3, Line 67: system_specific_params.append({'stk_parameter': stk_parameter})
Well, this is literally what the code does: […]
I am not sure. This was only a suggestion. If you think this is too much verbosity, than this is fine with me.
File tests/unittests/test_globalplatform.py:
Patch Set #3, Line 298: load_parameters = gen_install_parameters()
Not sure what you mean where, but let me explain why I am changing this line. […]
Thanks. I now understand. This worked before because of the bug in install_param.py, which is now fixed.
To view, visit change 42378. To unsubscribe, or for help writing mail filters, visit settings.