Attention is currently required from: laforge.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 17: tread

    treat

    Done

  • Patch Set #1, Line 27: the tread

    "to treat the header"? Not sure what you mean

    Done

• File pySim/esim/es2p.py:

  • Patch Set #1, Line 252: The API user is expected to override

    wouldn't it be better to have an abc. […]

    My original idea is that that the APU user only overrides the methods he needs. The other methods then would still exist, but requests would return Failed.

    I have thought a bit about this and now I think that an approach with abstract classes is indeed better since it is more specific. The SMDP+ side should always implement all methods expect the one for call_handleDownloadProgressInfo and on the MNO side we should see call_handleDownloadProgressInfo as the only method. The class model now reflects that.

To view, visit change 41874. To unsubscribe, or for help writing mail filters, visit settings.