Attention is currently required from: Hoernchen.
756 comments:
File smdpp/bsp_crypto.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 37: typedef struct ReplaceSessionKeysRequest_ASN1_st {
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 38: ASN1_OCTET_STRING* initialMacChainingValue;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 39: ASN1_OCTET_STRING* ppkEnc;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: ASN1_OCTET_STRING* ppkCmac;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: typedef ReplaceSessionKeysRequest_ASN1 ReplaceSessionKeysRequest_outer;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 52: typedef ASN1_INTEGER RemoteOpId;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 56: typedef struct ControlRefTemplate_st {
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 57: ASN1_OCTET_STRING* keyType;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 58: ASN1_OCTET_STRING* keyLen;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 59: ASN1_OCTET_STRING* hostId;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 65: typedef ASN1_OCTET_STRING SmdpOtpk;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: typedef ASN1_OCTET_STRING SmdpSign;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: typedef struct InitialiseSecureChannelRequest_ASN1_st {
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 73: RemoteOpId* remoteOpId;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 74: ASN1_OCTET_STRING* transactionId;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 75: ControlRefTemplate* controlRefTemplate;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: SmdpOtpk* smdpOtpk;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 77: SmdpSign* smdpSign;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 83: typedef InitialiseSecureChannelRequest_ASN1 InitialiseSecureChannelRequest_tagged;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: typedef ASN1_OCTET_STRING ASN1_OCTET_STRING_TAG7;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 88: typedef ASN1_OCTET_STRING ASN1_OCTET_STRING_TAG8;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 89: typedef ASN1_OCTET_STRING ASN1_OCTET_STRING_TAG6;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: typedef struct BoundProfilePackage_st {
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 101: InitialiseSecureChannelRequest_tagged* initialiseSecureChannelRequest;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 111: typedef BoundProfilePackage BoundProfilePackage_tagged;
do not add new typedefs
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 116: void operator()(BoundProfilePackage_tagged* ss1) const;
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 116: void operator()(BoundProfilePackage_tagged* ss1) const;
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: void operator()(ReplaceSessionKeysRequest_outer* ss1) const;
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: void operator()(ReplaceSessionKeysRequest_outer* ss1) const;
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 124: void operator()(EVP_CIPHER_CTX* ctx) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 124: void operator()(EVP_CIPHER_CTX* ctx) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 131: void operator()(EVP_MAC_CTX* ctx) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 131: void operator()(EVP_MAC_CTX* ctx) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 138: void operator()(EVP_MAC* mac) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 138: void operator()(EVP_MAC* mac) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 144: using BPP_ptr = std::unique_ptr<BoundProfilePackage_tagged, BoundProfilePackage_tagged_Deleter>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 144: using BPP_ptr = std::unique_ptr<BoundProfilePackage_tagged, BoundProfilePackage_tagged_Deleter>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 145: using RPK_ptr = std::unique_ptr<ReplaceSessionKeysRequest_outer, ReplaceSessionKeysRequest_outer_Deleter>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 145: using RPK_ptr = std::unique_ptr<ReplaceSessionKeysRequest_outer, ReplaceSessionKeysRequest_outer_Deleter>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 146: using EVP_CIPHER_CTX_unique_ptr = std::unique_ptr<EVP_CIPHER_CTX, EVP_CIPHER_CTX_Deleter>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 146: using EVP_CIPHER_CTX_unique_ptr = std::unique_ptr<EVP_CIPHER_CTX, EVP_CIPHER_CTX_Deleter>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 147: using EVP_MAC_CTX_unique_ptr = std::unique_ptr<EVP_MAC_CTX, EVP_MAC_CTX_Deleter>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 147: using EVP_MAC_CTX_unique_ptr = std::unique_ptr<EVP_MAC_CTX, EVP_MAC_CTX_Deleter>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 148: using EVP_MAC_unique_ptr = std::unique_ptr<EVP_MAC, EVP_MAC_Deleter>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 148: using EVP_MAC_unique_ptr = std::unique_ptr<EVP_MAC, EVP_MAC_Deleter>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 151: private:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 156: std::vector<uint8_t> s_enc;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 156: std::vector<uint8_t> s_enc;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 156: std::vector<uint8_t> s_enc;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 157: std::vector<uint8_t> s_mac;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 157: std::vector<uint8_t> s_mac;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 157: std::vector<uint8_t> s_mac;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 158: std::vector<uint8_t> mac_chain;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 158: std::vector<uint8_t> mac_chain;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 158: std::vector<uint8_t> mac_chain;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 161: static std::vector<uint8_t> compute_cmac(const std::vector<uint8_t>& key, const std::vector<uint8_t>& data, size_t output_size = AES_BLOCK_SIZE);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: std::vector<uint8_t> aes_cipher_operation(const std::vector<uint8_t>& input, const std::vector<uint8_t>& key, const std::vector<uint8_t>& iv,
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 166: static std::vector<uint8_t> encode_bertlv_length(size_t length);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 166: static std::vector<uint8_t> encode_bertlv_length(size_t length);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 168: static void print_hex(const std::string& label, const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 169: static void print_hex(const char* label, const unsigned char* data, int len);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 169: static void print_hex(const char* label, const unsigned char* data, int len);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 171: static std::pair<size_t, size_t> parse_bertlv_length(const std::vector<uint8_t>& data, size_t offset);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 173: std::vector<uint8_t> verify_and_decrypt_helper(const std::vector<uint8_t>& segment, const std::vector<uint8_t>& mac_chain_to_use, bool decrypt);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 175: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 176: BspCrypto(const std::vector<uint8_t>& s_enc_key, const std::vector<uint8_t>& s_mac_key, const std::vector<uint8_t>& initial_mcv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 178: static std::vector<uint8_t> x963_kdf_sha256(const std::vector<uint8_t>& shared_secret, const std::vector<uint8_t>& shared_info, size_t output_length);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 180: static BspCrypto from_kdf(const std::vector<uint8_t>& shared_secret, uint8_t key_type, uint8_t key_length, const std::vector<uint8_t>& host_id,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 181: const std::vector<uint8_t>& eid);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 181: const std::vector<uint8_t>& eid);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 181: const std::vector<uint8_t>& eid);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 181: const std::vector<uint8_t>& eid);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 183: std::vector<uint8_t> generate_icv();
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 183: std::vector<uint8_t> generate_icv();
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 183: std::vector<uint8_t> generate_icv();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 184: std::vector<uint8_t> add_padding(const std::vector<uint8_t>& data);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 185: std::vector<uint8_t> remove_padding(const std::vector<uint8_t>& data);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 186: std::vector<uint8_t> aes_encrypt(const std::vector<uint8_t>& plaintext);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 187: std::vector<uint8_t> aes_decrypt_with_icv(const std::vector<uint8_t>& ciphertext, const std::vector<uint8_t>& icv);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 188: std::vector<uint8_t> generate_icv_for_block(uint32_t block_num);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 188: std::vector<uint8_t> generate_icv_for_block(uint32_t block_num);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 188: std::vector<uint8_t> generate_icv_for_block(uint32_t block_num);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 189: std::vector<uint8_t> compute_mac(uint8_t tag, const std::vector<uint8_t>& data);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::vector<uint8_t> encrypt_and_mac_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: std::vector<uint8_t> decrypt_and_verify(const std::vector<uint8_t>& segments, bool decrypt = true);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 194: std::vector<uint8_t> ppkEnc;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 194: std::vector<uint8_t> ppkEnc;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 194: std::vector<uint8_t> ppkEnc;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 195: std::vector<uint8_t> ppkCmac;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 195: std::vector<uint8_t> ppkCmac;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 195: std::vector<uint8_t> ppkCmac;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 196: std::vector<uint8_t> initialMacChainingValue;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 196: std::vector<uint8_t> initialMacChainingValue;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 196: std::vector<uint8_t> initialMacChainingValue;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 199: static std::vector<uint8_t> asn1_octet_string_to_vector(const ASN1_OCTET_STRING* asn1_str);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 199: static std::vector<uint8_t> asn1_octet_string_to_vector(const ASN1_OCTET_STRING* asn1_str);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 199: static std::vector<uint8_t> asn1_octet_string_to_vector(const ASN1_OCTET_STRING* asn1_str);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 200: static ReplaceSessionKeysRequest parse_replace_session_keys(const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 201: static BspCrypto from_replace_session_keys(const ReplaceSessionKeysRequest& rsk);
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 204: std::vector<uint8_t> configureIsdp;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 204: std::vector<uint8_t> configureIsdp;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 204: std::vector<uint8_t> configureIsdp;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 205: std::vector<uint8_t> storeMetadata;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 205: std::vector<uint8_t> storeMetadata;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 205: std::vector<uint8_t> storeMetadata;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 207: std::vector<uint8_t> profileData;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 207: std::vector<uint8_t> profileData;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 207: std::vector<uint8_t> profileData;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& allofit);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: BppProcessingResult process_bound_profile_package(const std::vector<uint8_t>& firstSequenceOf87, const std::vector<uint8_t>& sequenceOf88,
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 214: const std::vector<uint8_t>& secondSequenceOf87, const std::vector<uint8_t>& sequenceOf86);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 216: void reset(const std::vector<uint8_t>& initial_mcv);
function definition argument 'uint8_t' should also have an identifier name
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: static std::vector<uint8_t> generate_replace_session_keys_data(const std::vector<uint8_t>& ppk_enc, const std::vector<uint8_t>& ppk_mac,
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 219: const std::vector<uint8_t>& initial_mcv);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 219: const std::vector<uint8_t>& initial_mcv);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 219: const std::vector<uint8_t>& initial_mcv);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 219: const std::vector<uint8_t>& initial_mcv);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 221: std::vector<uint8_t> mac_only_one(uint8_t tag, const std::vector<uint8_t>& plaintext);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 222: std::vector<std::vector<uint8_t>> encrypt_and_mac_seg(uint8_t tag, const std::vector<uint8_t>& data);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
need consistent spacing around '>>' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 223: std::vector<std::vector<uint8_t>> mac_only_seg(uint8_t tag, const std::vector<uint8_t>& data);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 228: #endif // BSP_CRYPTO_H
adding a line without newline at end of file
File smdpp/helpers.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) {
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) {
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: std::ostream& operator<<(std::ostream& os, const std::vector<std::string>& v) {
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: copy(v.begin(), v.end(), std::ostream_iterator<std::string>(os, "\n"));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: copy(v.begin(), v.end(), std::ostream_iterator<std::string>(os, "\n"));
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: std::string to_string(const std::vector<std::string>& vec) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: std::string to_string(const std::vector<std::string>& vec) {
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: std::string to_string(const std::vector<std::string>& vec) {
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: std::string to_string(const std::vector<std::string>& vec) {
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: std::ostringstream oss;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) {
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) {
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: std::string operator+(const std::string& str, const std::vector<std::string>& vec) {
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) {
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) {
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) {
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 17: std::string operator+(const std::vector<std::string>& vec, const std::string& str) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 24: void operator()(BIO* bio) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 24: void operator()(BIO* bio) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 30: void operator()(X509* cert) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 30: void operator()(X509* cert) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 36: void operator()(X509_STORE* store) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 36: void operator()(X509_STORE* store) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 42: void operator()(X509_STORE_CTX* ctx) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 42: void operator()(X509_STORE_CTX* ctx) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 48: void operator()(EVP_PKEY* key) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 48: void operator()(EVP_PKEY* key) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 54: void operator()(EVP_MD_CTX* ctx) const {
Bad function definition - void operator() should probably be void operator(void)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 54: void operator()(EVP_MD_CTX* ctx) const {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 60: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 61: static std::vector<uint8_t> decode(const std::string& b64message) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 61: static std::vector<uint8_t> decode(const std::string& b64message) {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 61: static std::vector<uint8_t> decode(const std::string& b64message) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 62: if (b64message.empty()) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 68: if (b64message[b64message.size() - 1] == '=' && b64message[b64message.size() - 2] == '=') {
braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: std::vector<uint8_t> buffer(decodeLen);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: std::vector<uint8_t> buffer(decodeLen);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 76: std::vector<uint8_t> buffer(decodeLen);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: BIO* b64 = BIO_new(BIO_f_base64());
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 81: BIO* mem = BIO_new_mem_buf(b64message.c_str(), -1);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 82: BIO* bioChain = BIO_push(b64, mem);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 84: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 84: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 84: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 87: if (length <= 0) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: static std::string encode(const std::vector<uint8_t>& data) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: static std::string encode(const std::vector<uint8_t>& data) {
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: static std::string encode(const std::vector<uint8_t>& data) {
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 95: static std::string encode(const std::vector<uint8_t>& data) {
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 96: if (data.empty()) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 100: BIO* b64 = BIO_new(BIO_f_base64());
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 103: BIO* mem = BIO_new(BIO_s_mem());
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 104: BIO* bioChain = BIO_push(b64, mem);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 106: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 106: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 106: std::unique_ptr<BIO, BIODeleter> bioPtr(bioChain);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 111: BUF_MEM* bufferPtr;
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 119: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: static std::vector<uint8_t> hexToBytes(const std::string& hex) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: static std::vector<uint8_t> hexToBytes(const std::string& hex) {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 120: static std::vector<uint8_t> hexToBytes(const std::string& hex) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 121: if (hex.length() % 2 != 0) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 125: std::vector<uint8_t> bytes(hex.length() / 2);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 125: std::vector<uint8_t> bytes(hex.length() / 2);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 125: std::vector<uint8_t> bytes(hex.length() / 2);
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 126: for (size_t i = 0; i < bytes.size(); ++i) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 127: sscanf(hex.c_str() + (i * 2), "%2hhx", &bytes[i]);
unchecked sscanf return value
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) {
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) {
space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 133: static std::string bytesToHex(const std::vector<uint8_t>& bytes) {
space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 137: static std::string bytesToHex(const uint8_t* data, size_t length) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 138: std::stringstream ss;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: for (size_t i = 0; i < length; ++i) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 142: ss << std::setw(2) << static_cast<int>(data[i]);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 142: ss << std::setw(2) << static_cast<int>(data[i]);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 149: } // namespace RspCrypto
adding a line without newline at end of file
File smdpp/logger.h:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 63: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 66: static void log(Level level, const std::string& message, const char* filename = nullptr, int line = 0) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 66: static void log(Level level, const std::string& message, const char* filename = nullptr, int line = 0) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 66: static void log(Level level, const std::string& message, const char* filename = nullptr, int line = 0) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 70: std::string levelStr;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 72: case Level::DEBUG:
spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 75: case Level::INFO:
spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 78: case Level::WARNING:
spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 81: case Level::ERROR:
spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 86: std::stringstream ss;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 92: const char* base_filename = strrchr(filename, '/');
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 93: if (!base_filename) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 103: std::cout << ss.str() << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 106: static void debug(const std::string& message, const char* filename = nullptr, int line = 0) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 106: static void debug(const std::string& message, const char* filename = nullptr, int line = 0) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 106: static void debug(const std::string& message, const char* filename = nullptr, int line = 0) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: static void info(const std::string& message, const char* filename = nullptr, int line = 0) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: static void info(const std::string& message, const char* filename = nullptr, int line = 0) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 110: static void info(const std::string& message, const char* filename = nullptr, int line = 0) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 114: static void warning(const std::string& message, const char* filename = nullptr, int line = 0) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 114: static void warning(const std::string& message, const char* filename = nullptr, int line = 0) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 114: static void warning(const std::string& message, const char* filename = nullptr, int line = 0) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 118: static void error(const std::string& message, const char* filename = nullptr, int line = 0) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 118: static void error(const std::string& message, const char* filename = nullptr, int line = 0) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 118: static void error(const std::string& message, const char* filename = nullptr, int line = 0) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 130: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 131: OpenSSLError(const std::string& message) : std::runtime_error(message + getOpenSSLErrors()) {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 134: private:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 136: std::stringstream ss;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 141: char* err_str = ERR_error_string(err, nullptr);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 150: public:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 153: std::stringstream errorStream;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 160: const char* library = ERR_lib_error_string(errorCode);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 163: const char* function = ERR_func_error_string(errorCode);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 165: const char* reason = ERR_reason_error_string(errorCode);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 181: static std::string getSSLError(SSL* ssl, int result) {
need consistent spacing around '*' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 183: std::stringstream errorStream;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 190: std::string queueErrors = getLastError();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 191: if (!queueErrors.empty()) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 199: std::stringstream errorStream;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 202: const char* errorString = X509_verify_cert_error_string(verifyResult);
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: static void printSSLErrors(const std::string& context = "") {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 211: static void printSSLErrors(const std::string& context = "") {
need consistent spacing around '&' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 212: if (!context.empty()) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 213: std::cerr << "=== " << context << " ===" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 216: std::string errors = getLastError();
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 217: if (!errors.empty()) {
braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 218: std::cerr << errors << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 220: std::cerr << "No OpenSSL errors in queue." << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 224: private:
labels should not be indented
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 251: } // namespace RspCrypto
adding a line without newline at end of file
File smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN CERTIFICATE-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MIICUTCCAfigAwIBAgIJALh086v6bETTMAoGCCqGSM49BAMCMEQxEDAOBgNVBAMM
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: B1Rlc3QgQ0kxETAPBgNVBAsMCFRFU1RDRVJUMRAwDgYDVQQKDAdSU1BURVNUMQsw
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: CQYDVQQGEwJJVDAgFw0yMDA0MDEwODI3NTFaGA8yMDU1MDQwMTA4Mjc1MVowRDEQ
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MA4GA1UEAwwHVGVzdCBDSTERMA8GA1UECwwIVEVTVENFUlQxEDAOBgNVBAoMB1JT
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: UFRFU1QxCzAJBgNVBAYTAklUMFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABCeH
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: tNVu2CSp5r4E4Yh/a5i6/rjHY/UoN/cBE+k2Tt2+E5vAx95+Fo8eXNDBhTT8UGTm
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: T2htxTMnyn8dzqhaKZSjgc8wgcwwHQYDVR0OBBYEFMC8cLo2kp1DtGf/V1cFMOV6
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: uPzYMA8GA1UdEwEB/wQFMAMBAf8wFwYDVR0gAQH/BA0wCzAJBgdngRIBAgEAMA4G
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: A1UdDwEB/wQEAwIBBjAOBgNVHREEBzAFiAOINwEwYQYDVR0fBFowWDAqoCigJoYk
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: aHR0cDovL2NpLnRlc3QuZXhhbXBsZS5jb20vQ1JMLUEuY3JsMCqgKKAmhiRodHRw
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 12: Oi8vY2kudGVzdC5leGFtcGxlLmNvbS9DUkwtQi5jcmwwCgYIKoZIzj0EAwIDRwAw
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: RAIgPYrf0CKl0FBMUaHx5xS1duTDbQ4wBZN3qKBeNniuux0CIHBek2vLfoANAdtt
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 14: f5u5Ce6DVC2oIfpn5UnS24F3oMqM
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 15: -----END CERTIFICATE-----
DOS line endings
File smdpp/sgp26/CertificateIssuer/CERT_CI_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN CERTIFICATE-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MIICUDCCAfegAwIBAgIJALh086v6bETTMAoGCCqGSM49BAMCMEQxEDAOBgNVBAMM
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: B1Rlc3QgQ0kxETAPBgNVBAsMCFRFU1RDRVJUMRAwDgYDVQQKDAdSU1BURVNUMQsw
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: CQYDVQQGEwJJVDAgFw0yMDA0MDEwODI3NTFaGA8yMDU1MDQwMTA4Mjc1MVowRDEQ
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MA4GA1UEAwwHVGVzdCBDSTERMA8GA1UECwwIVEVTVENFUlQxEDAOBgNVBAoMB1JT
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: UFRFU1QxCzAJBgNVBAYTAklUMFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAElAZX
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: pnPcKI+J1S6opHcEmSeR+cNLADbmM+LQy6lFTWXbMusXmBeZ0vJDiO4rlcEJRUbJ
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: eQHOrrqWUJGaLiDSKaOBzzCBzDAdBgNVHQ4EFgQU9UFyvfmKldZcvriKOKHBHYAK
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: hcMwDwYDVR0TAQH/BAUwAwEB/zAXBgNVHSABAf8EDTALMAkGB2eBEgECAQAwDgYD
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: VR0PAQH/BAQDAgEGMA4GA1UdEQQHMAWIA4g3ATBhBgNVHR8EWjBYMCqgKKAmhiRo
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: dHRwOi8vY2kudGVzdC5leGFtcGxlLmNvbS9DUkwtQS5jcmwwKqAooCaGJGh0dHA6
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 12: Ly9jaS50ZXN0LmV4YW1wbGUuY29tL0NSTC1CLmNybDAKBggqhkjOPQQDAgNHADBE
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: AiBSdWqvwgIKbOy/Ll88IIklEP8pdR0pi9OwFdlgWk/mfQIgV5goNuTSBd3S5sPB
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 14: tFWTf2tuSTtgL9G2bDV0iak192s=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 15: -----END CERTIFICATE-----
DOS line endings
File smdpp/sgp26/CertificateIssuer/CI-csr.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: #openssl x509 extfile params
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: extensions = extend
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: # This prevent the user to be prompted for values
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: prompt = no
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: distinguished_name = dn-param
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: [dn-param] # DN fields
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: CN = Test CI
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: OU = TESTCERT
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: O = RSPTEST
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: C = IT
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: # Extensions for the Test CI
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 14: [extend] # openssl extensions
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 15: subjectKeyIdentifier = hash
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 17: basicConstraints = critical, CA:true
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 19: certificatePolicies=critical,2.23.146.1.2.1.0
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 21: keyUsage =critical, keyCertSign, cRLSign
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 23: subjectAltName = RID:2.999.1
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/CertificateIssuer/SK_CI_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BgkrJAMDAggBAQc=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHgCAQEEIDWGs5Vx2Xz5Y17YWnRQ4tJYmTEJQ9ossf2KHmdLa/b0oAsGCSskAwMC
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: CAEBB6FEA0IABCeHtNVu2CSp5r4E4Yh/a5i6/rjHY/UoN/cBE+k2Tt2+E5vAx95+
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: Fo8eXNDBhTT8UGTmT2htxTMnyn8dzqhaKZQ=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABC7uB8ltAFvlGV95rR2tzR03jKMJ
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: XkT3LupBDwjHVhIskGPJZbf8hSnAyk6bT2WWnCg8ZWNkV4dxGPbRFy1qI2U=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/DPauth/PK_S_SM_DP2auth_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEKy6bRdNRwJr0DpFDg6GQOEfyYH3m
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: DverJcQOA/jbtlCOFFdQjCvgAXNH7Pob+fd159B+gF5S4ZiLe1hacRGuMw==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BgkrJAMDAggBAQc=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHgCAQEEIAwXNVwBHQ/o19rdY/GXhc9sUcvNRmroi+j4G8EFiEb2oAsGCSskAwMC
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: CAEBB6FEA0IABC7uB8ltAFvlGV95rR2tzR03jKMJXkT3LupBDwjHVhIskGPJZbf8
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: hSnAyk6bT2WWnCg8ZWNkV4dxGPbRFy1qI2U=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/DPauth/SK_S_SM_DP2auth_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BggqhkjOPQMBBw==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHcCAQEEIJwyoJXUiELZ/6QE9xJRKqLFQloaJjhqtqFF1YEeA5FBoAoGCCqGSM49
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: AwEHoUQDQgAEKy6bRdNRwJr0DpFDg6GQOEfyYH3mDverJcQOA/jbtlCOFFdQjCvg
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: AXNH7Pob+fd159B+gF5S4ZiLe1hacRGuMw==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABHNhhV5ZAmSyUscaYGKgIeJ7Rvdg
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: uBOCBqf3RCDvi8Vai5iNFlj51w06LYSAqt9k5ixNcSfeWgorkXqUP0R0qt0=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/DPpb/PK_S_SM_DP2pb_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEPi11oQYiEhbCruj61YT3eWM8+URo
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: G17HWpZlP19AHEdq451UbAMtMtAHCnuG5dzrqt3zHKXCdmwZa9ebwhoBgA==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BgkrJAMDAggBAQc=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHgCAQEEIJyuLhpWB6nVeDgu7pMuJR9SME+G7rHxcIzb08B74s09oAsGCSskAwMC
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: CAEBB6FEA0IABHNhhV5ZAmSyUscaYGKgIeJ7RvdguBOCBqf3RCDvi8Vai5iNFlj5
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: 1w06LYSAqt9k5ixNcSfeWgorkXqUP0R0qt0=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/DPpb/SK_S_SM_DP2pb_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BggqhkjOPQMBBw==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHcCAQEEIGaTEUljnbqsHcPTBsWL0t/SL3O/Y6yGMZgykLV/kJNFoAoGCCqGSM49
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: AwEHoUQDQgAEPi11oQYiEhbCruj61YT3eWM8+URoG17HWpZlP19AHEdq451UbAMt
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: MtAHCnuG5dzrqt3zHKXCdmwZa9ebwhoBgA==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.csr.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: [ req ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: prompt = no
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: distinguished_name = req_distinguished_name
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: [ req_distinguished_name ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: O = ACME
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS2
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: CN = testsmdpplus2.example.com
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP2_TLS.ext.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: ######################################################################################################################################################################
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: # Extensions for a DPTLS
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: keyUsage = critical, digitalSignature
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: certificatePolicies = 2.23.146.1.2.1.3
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: subjectKeyIdentifier = hash
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: authorityKeyIdentifier = keyid:always,issuer
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID2
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS2
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: subjectAltName = DNS:testsmdpplus2.example.com, RID:2.999.12
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl
trailing whitespace
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.csr.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: [ req ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: prompt = no
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: distinguished_name = req_distinguished_name
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: [ req_distinguished_name ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: O = ACME
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS4
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: CN = testsmdpplus4.example.com
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP4_TLS.ext.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: ######################################################################################################################################################################
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: # Extensions for a DPTLS
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: keyUsage = critical, digitalSignature
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: certificatePolicies = 2.23.146.1.2.1.3
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: subjectKeyIdentifier = hash
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: authorityKeyIdentifier = keyid:always,issuer
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID4
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS4
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: subjectAltName = DNS:testsmdpplus4.example.com, RID:2.999.14
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl
trailing whitespace
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.csr.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: [ req ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: prompt = no
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: distinguished_name = req_distinguished_name
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: [ req_distinguished_name ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: O = ACME
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS8
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: CN = testsmdpplus8.example.com
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP8_TLS.ext.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: ######################################################################################################################################################################
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: # Extensions for a DPTLS
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: keyUsage = critical, digitalSignature
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: certificatePolicies = 2.23.146.1.2.1.3
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: subjectKeyIdentifier = hash
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: authorityKeyIdentifier = keyid:always,issuer
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID8
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS8
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: subjectAltName = DNS:testsmdpplus8.example.com, RID:2.999.18
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl
trailing whitespace
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.csr.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: [ req ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: prompt = no
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: distinguished_name = req_distinguished_name
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: [ req_distinguished_name ]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: O = ACME
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: # shall be aligned with SGP.23 value #TEST_DP_ADDRESS1
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: CN = testsmdpplus1.example.com
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/DPtls/CERT_S_SM_DP_TLS.ext.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: ######################################################################################################################################################################
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: # Extensions for a DPTLS
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: keyUsage = critical, digitalSignature
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: extendedKeyUsage = critical, serverAuth, clientAuth
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: certificatePolicies = 2.23.146.1.2.1.3
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: subjectKeyIdentifier = hash
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: authorityKeyIdentifier = keyid:always,issuer
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: # RID shall be aligend with SGP.23 value SM-DP+OID
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: # DNS name shall be aligned with SGP.23 value #TEST_DP_ADDRESS1
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: subjectAltName = DNS:testsmdpplus1.example.com, RID:2.999.10
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: crlDistributionPoints=URI:http://ci.test.example.com/CRL-A.crl, URI:http://ci.test.example.com/CRL-B.crl
trailing whitespace
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/sgp26/EUM/EUM-csr.cnf:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: [req]
trailing whitespace
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: [dn-name]
trailing whitespace
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: commonName = EUM Test
trailing whitespace
File smdpp/sgp26/EUM/EUM-ext.cnf:
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: # openssl EUM certificate creation configuration file
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: authorityKeyIdentifier=keyid, issuer
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: subjectKeyIdentifier=hash
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: keyUsage=critical, keyCertSign
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: certificatePolicies=critical,2.23.146.1.2.1.2 #OID id-rspRole-eum
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: subjectAltName=RID:2.999.5
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: basicConstraints=critical,CA:TRUE, pathlen:0
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 11: crlDistributionPoints=URI:http://ci.test.example.com/CRL-B.crl
trailing whitespace
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 13: nameConstraints=critical,DER:30:32:A0:30:30:2E:A4:2C:30:2A:31:15:30:13:06:03:55:04:0A:0C:0C:52:53:50:20:54:65:73:74:20:45:55:4D:31:11:30:0F:06:03:55:04:05:13:08:38:39:30:34:39:30:33:32
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 18: # TBSCertificate
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 19: #0000: 30 82 02 7c ; SEQUENCE
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 20: #0004: 30 82 02 21 ; SEQUENCE
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 21: #0008: | a0 03 ; OPTIONAL[0]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 22: #000a: | | 02 01 02 ; INTEGER - Version = 2(log. 3)
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 24: #0120: | a3 82 01 05 ; OPTIONAL[3] - Extensions : tag = [3]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 25: #0124: | 30 82 01 01 ; SEQUENCE - OF Extension
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 26: # ...
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 27: #01e9: | 30 3e ; SEQUENCE
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 28: #01eb: | 06 03 55 1d 1e ; OBJECT_ID - 2.5.29.30 Name Constraints
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 29: #01f0: | 01 01 ff ; BOOL - critical=TRUE
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 30: #01f3: | 04 34 ; OCTET_STRING - extnValue(CONTAINING NameConstraints)
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 31: # -------------------------------------DER input data ----------------------------------------------------------------------------------
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 32: #01f5: | 30 32 ; SEQUENCE - NameConstraints
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 33: #01f7: | a0 30 ; OPTIONAL[0] - permittedSubtrees : tag = [0]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 34: #01f9: | 30 2e ; SEQUENCE - GeneralSubtrees of GeneralSubtree
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 35: #01fb: | a4 2c ; OPTIONAL[4] - base GeneralName CHOICE directoryName : tag = [4]
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 36: #01fd: | | 30 2a ; SEQUENCE - Name CHOICE rdnSequence RDNSequence
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 37: #01ff: | | 31 15 ; SET - RelativeDistinguishedName
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 38: #0201: | | 30 13 ; SEQUENCE - AttributeTypeAndValue
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 39: #0203: | | | 06 03 ; OBJECT_ID - AttributeType
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 40: #0205: | | | | 55 04 0a - 2.5.4.10 Organization (O)
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 41: #0208: | | | 0c 0c ; UTF8_STRING - AttributeValue
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 42: #020a | 52 53 50 20 74 65 73 74 65 75 4D - RSP Test EUM
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 43: #0216 | 31 11
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 44: #0218: | 30 0f ; SEQUENCE
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 45: #021a: | 06 03 ; OBJECT_ID - AttributeType
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 46: #021c: | | 55 04 05 - 2.5.4.5 Serial Number (SERIALNUMBER)
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 47: #021f: | 13 08 ; PRINTABLE_STRING - AttributeValue
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 48: #0221: | 38 39 30 34 39 30 33 32 - 89049032
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 50: #--------------------------------------------------------------------------------------------------------------------------------
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 51: #0229: 30 0a ; SEQUENCE (a Bytes)
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
trailing whitespace
File smdpp/sgp26/EUM/PK_EUM_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABKLlKjLf6JllccU69TKO9oIJP8HQ
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: X1JlL2txHCQ4IffxawzsjSGbI9P5kPQ00LkNQnFsAuCTBSZEY/YR5lDDf/c=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/EUM/PK_EUM_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEEzDVklasDLUL2SjQ9MaAB8SF/j9C
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: mIrT7jh1rjP0mDqyO03UwxNA1nbdjhH5xcuhsR62lO7QmU21KSheYyyJBg==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/EUM/SK_EUM_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BgkrJAMDAggBAQc=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHgCAQEEIBKbCrE/F+FKQLb6Ttgj4M9GW3s9cyQF5ildOyOwRcmaoAsGCSskAwMC
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: CAEBB6FEA0IABKLlKjLf6JllccU69TKO9oIJP8HQX1JlL2txHCQ4IffxawzsjSGb
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: I9P5kPQ00LkNQnFsAuCTBSZEY/YR5lDDf/c=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/EUM/SK_EUM_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BggqhkjOPQMBBw==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHcCAQEEICXmdXco4elRE1Gc3DRVXCm67SN3OsWv3dza2YSJilLwoAoGCCqGSM49
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: AwEHoUQDQgAEEzDVklasDLUL2SjQ9MaAB8SF/j9CmIrT7jh1rjP0mDqyO03UwxNA
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: 1nbdjhH5xcuhsR62lO7QmU21KSheYyyJBg==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/eUICC/PK_EUICC_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFowFAYHKoZIzj0CAQYJKyQDAwIIAQEHA0IABD5ZDDipwlYxXs/zKRQW3TNUCaZm
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: /UGztR5eURTzQ6vwomd0xsJsSHU6/ig2QyJ7tmCM0mHMly03SkeRJOvydyI=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/eUICC/PK_EUICC_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN PUBLIC KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEbbP1OtyH3C/xDHv82HrROulwCa+g
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: ZaZ1fuVxs/LrsY9GwdaPPt6w50suXVQgUefSf1CVIChgWv3vef6f/9A5WQ==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----END PUBLIC KEY-----
DOS line endings
File smdpp/sgp26/eUICC/SK_EUICC_ECDSA_BRP.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BgkrJAMDAggBAQc=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHgCAQEEII3DR6dtt73WIi3XXqGhaIrKgR5MvGp/au+ksmQZYguQoAsGCSskAwMC
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: CAEBB6FEA0IABD5ZDDipwlYxXs/zKRQW3TNUCaZm/UGztR5eURTzQ6vwomd0xsJs
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: SHU6/ig2QyJ7tmCM0mHMly03SkeRJOvydyI=
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/eUICC/SK_EUICC_ECDSA_NIST.pem:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 1: -----BEGIN EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: BggqhkjOPQMBBw==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 3: -----END EC PARAMETERS-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: -----BEGIN EC PRIVATE KEY-----
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 5: MHcCAQEEIBHhVGfcGU8zcYPkYMn2MmAJHhLoECbNZWHhfG2FOcycoAoGCCqGSM49
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 6: AwEHoUQDQgAEbbP1OtyH3C/xDHv82HrROulwCa+gZaZ1fuVxs/LrsY9GwdaPPt6w
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: 50suXVQgUefSf1CVIChgWv3vef6f/9A5WQ==
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: -----END EC PRIVATE KEY-----
DOS line endings
File smdpp/sgp26/eUICC/eUICC-csr.cnf:
Robot Comment from checkpatch (run ID ):
trailing whitespace
File smdpp/sgp26/eUICC/eUICC-ext.cnf:
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 2: #eUICC certificate creation configuration
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 4: # use openssl x509 -req -in eUICC-csr.cnf -CA ..\CERT_EUM_ECDSA_NIST.pem -CAkey ..\SK_EUM_ECDSA_NIST.pem -set_serial 0x020000000000000001 -days 2000000 -sha256 -extfile eUICC-ext.cnf -out CERT_EUICC_ECDSA_NIST.pem
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 7: authorityKeyIdentifier=keyid
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 8: subjectKeyIdentifier=hash
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 9: keyUsage = critical, digitalSignature
DOS line endings
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 10: certificatePolicies=critical,2.23.146.1.2.1.1 #OID id-rspRole-e
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
Robot Comment from checkpatch (run ID ):
DOS line endings
File smdpp/smdpp_Tests_Functions.cc:
Robot Comment from checkpatch (run ID ):
Patch Set #3, Line 537: LOG_DEBUG(" Key type: " + std::to_string(keyType.get_long_long_val()) +
trailing whitespace
Robot Comment from checkpatch (run ID ):
trailing whitespace
To view, visit change 41119. To unsubscribe, or for help writing mail filters, visit settings.