Attention is currently required from: fixeria, pespin.
View Change
1 comment:
File src/common/l1sap.c:
Patch Set #2, Line 2098: switch (lchan->tch_mode) {
> the only valid modes are 6.0k and 3.6k raw rates, and my code does OSMO_ASSERT on all others. […]
Please see the new patch iteration: I implemented your approach, although I found it simpler to do the assert check on `bits_per_20ms` rather than on lchan type. Is it good enough now?
To view, visit change 38553. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5
Gerrit-Change-Number: 38553
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Oct 2024 17:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon@freecalypso.org>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>