pespin submitted this change.

View Change

Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
Drop extern declarations of global sgsn_instance in source files

There's an extern declaration already in sgsn.h.

Change-Id: I2375e13c8436a069e8fe60136c8e1759a9adc2d1
---
M src/sgsn/gprs_gmm.c
M src/sgsn/gprs_sgsn.c
M src/sgsn/sgsn_cdr.c
3 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/src/sgsn/gprs_gmm.c b/src/sgsn/gprs_gmm.c
index 5505ba9..b12102e 100644
--- a/src/sgsn/gprs_gmm.c
+++ b/src/sgsn/gprs_gmm.c
@@ -67,8 +67,6 @@

#define PTMSI_ALLOC

-extern struct sgsn_instance *sgsn;
-
static const struct tlv_definition gsm48_gmm_att_tlvdef = {
.def = {
[GSM48_IE_GMM_CIPH_CKSN] = { TLV_TYPE_FIXED, 1 },
diff --git a/src/sgsn/gprs_sgsn.c b/src/sgsn/gprs_sgsn.c
index 9a3e983..c911b6a 100644
--- a/src/sgsn/gprs_sgsn.c
+++ b/src/sgsn/gprs_sgsn.c
@@ -61,7 +61,6 @@

#define GPRS_LLME_CHECK_TICK 30

-extern struct sgsn_instance *sgsn;
extern struct osmo_tdef sgsn_T_defs[];

LLIST_HEAD(sgsn_mm_ctxts);
diff --git a/src/sgsn/sgsn_cdr.c b/src/sgsn/sgsn_cdr.c
index ac0a6fd..c22a6ac 100644
--- a/src/sgsn/sgsn_cdr.c
+++ b/src/sgsn/sgsn_cdr.c
@@ -39,9 +39,6 @@
#include <stdio.h>
#include <inttypes.h>

-/* TODO...avoid going through a global */
-extern struct sgsn_instance *sgsn;
-
/**
* The CDR module will generate an entry like:
*

To view, visit change 30931. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I2375e13c8436a069e8fe60136c8e1759a9adc2d1
Gerrit-Change-Number: 30931
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged