Attention is currently required from: pespin, msuraev.
View Change
1 comment:
Patchset:
Patch Set #2:
I didm't do a thorough analysis myself, but agree with neels, if he thinks there is no code path leading to this. Certainly we don't want to check everything for NULL in our code base.
On the other hand, if we are sure that it's never NULL, we might add an OSMO_ASSERT().
To view, visit change 28892. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I235bdd42ea82e7b5a1a40f437ca34c49ad239c48
Gerrit-Change-Number: 28892
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: msuraev <msuraev@sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Aug 2022 05:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment