Attention is currently required from: falconia, neels, pespin.

View Change

3 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #2, Line 646: exist 3 different RTP payload formats

    There exist maybe lots of formats for HR, but there exist TWO widely deployed formats, plus we have […]

    I don't really see why we would need to declare which of those formats are more widely deployed than others.

    This comment is not an API doc but just a comment. It may be long but I'd rather have it than not have it.

  • Patch Set #2, Line 691: * consider the full RTP chain of a single call:

    (my idea so far, can be in a future patch, is to not send any HR payload to a peer until we have received its first packet;

    And what if both sides of the connection follow that policy? It will fail...

  • Patch Set #2, Line 698: will always be RFC 5993

    Ideally, according to 3GPP yes, but in practice, do we always convert to RFC5993? […]

    On AoIP, there is no discussion. It is always RFC5993 as that is what (likely, quoting from memory) 3GPP TS 48.103 mandates. On other interfaces it's a different story.

To view, visit change 39869. To unsubscribe, or for help writing mail filters, visit settings.