Attention is currently required from: laforge, pespin, daniel.
8 comments:
File include/osmocom/netif/ipa.h:
Patch Set #10, Line 6: #include <osmocom/netif/stream.h>
Not sure why ipa. […]
Done
Patch Set #10, Line 46: int osmo_ipa_segmentation_cb(struct msgb *msg);
This belongs in the previous commit
Done
File include/osmocom/netif/stream.h:
Patch Set #1, Line 28: /* TODO: Add protocols for
Done. […]
Done
File src/stream.c:
Patch Set #10, Line 39: #include <osmocom/gsm/ipa.h>
Not needed.
Done
File tests/stream/stream_test.c:
Patch Set #10, Line 540: osmo_stream_cli_set_addr(osc, "127.0.0.11");
better use 127.0.0.1 here, all IP addresses being available in linux specific iirc.
I don't understand the second part of the sentence...
I copied this from the existing test code for the other tests. Should that be changed as well then? Or can we just leave it at `127.0.0.11`?
Patch Set #10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start);
usually alarm() is used for this kind of stuff (exit process on timeout).
What is the advantage of using `alarm()` instead, and how wouldn't I need to register some sort of (additional, if it's already handled in lower layers) alarm handling for SIGALRM if I wanted a diagnostic message?
@daniel I prefer setting an amount of time to setting an amount of iterations, but maybe that's just me
I'd like to leave it as is if possible. Did try it out and it worked...
Patch Set #10, Line 629: rc = clock_gettime(CLOCK_MONOTONIC, &now);
osmo_clock_gettime. […]
(see Daniel's reply above)
Patch Set #10, Line 684: rc = test_segm_ipa_stream_srv_run(tall_test, host, port, srv);
we don't usually do this kind of return in tests. […]
Done
To view, visit change 33197. To unsubscribe, or for help writing mail filters, visit settings.