neels submitted this change.

View Change

silence compiler warning in gtlv_dec_enc.c

This was reported with gcc version 12.2.0:

 /git/libosmo-pfcp/src/libosmo-gtlv/gtlv_dec_enc.c: In function
 'osmo_gtlvs_decode_unordered':
 /git/libosmo-pfcp/src/libosmo-gtlv/gtlv_dec_enc.c:237:42: warning:
 'presence_flag_p' may be used uninitialized [-Wmaybe-uninitialized]
   237 |                         *presence_flag_p = true;
       |                                          ^
 /git/libosmo-pfcp/src/libosmo-gtlv/gtlv_dec_enc.c:113:23: note:
 'presence_flag_p' was declared here
   113 |                 bool *presence_flag_p;
       |                       ^~~~~~~~~~~~~~~

There is no actual code path that will use presence_flag_p
uninitialized, but it doesn't hurt to init with NULL.

Change-Id: I8f4c420f2182c607abb1ee5d1c8175eaeda904af
---
M src/libosmo-gtlv/gtlv_dec_enc.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libosmo-gtlv/gtlv_dec_enc.c b/src/libosmo-gtlv/gtlv_dec_enc.c
index 37e8a51..bbd9db7 100644
--- a/src/libosmo-gtlv/gtlv_dec_enc.c
+++ b/src/libosmo-gtlv/gtlv_dec_enc.c
@@ -110,7 +110,7 @@
 	 * any). */
 	for (;;) {
 		int rc;
-		bool *presence_flag_p;
+		bool *presence_flag_p = NULL;
 		unsigned int memb_next_array_idx;
 		unsigned int memb_ofs;
 		unsigned int ie_max_allowed_count;

To view, visit change 30815. To unsubscribe, or for help writing mail filters, visit settings.