Attention is currently required from: fixeria.

View Change

3 comments:

• File doc/examples/modem/modem.cfg:

  • Patch Set #2, Line 12: no shutdown

    'no shutdown' again? I understand the idea that the user may want to switch between APNs, or even ac […]

    I'm just following existing commands (same is used for a long time in osmo-ggsn), which I suppose even comes from old cisco-like VTY namings.

• File src/host/layer23/include/osmocom/bb/common/apn.h:

  • Patch Set #2, Line 62: //struct in6_addr v6_lladdr;

    TODO?

    Yes, I'm focusing on filling holes grain by grain, otherwise it's too many pieces and too much work and patches wouldn't be nice to review. This way also other can use stuff in there earlier while developing their own parts.

• File src/host/layer23/include/osmocom/bb/common/ms.h:

  • Patch Set #2, Line 94: gprs_settings

    Ideally, all settings should be in struct gsm_settings.

    I decided to split it into gsm_settings and gprs_settings since other apps may not need the GPRS part.

To view, visit change 30992. To unsubscribe, or for help writing mail filters, visit settings.