Attention is currently required from: daniel.
View Change
1 comment:
File src/core/osmo_io.c:
Patch Set #2, Line 106: talloc_steal(iofd, msg);
I wonder whether this is really needed. Isn't the msg being passed here always already parented to iofd now?
This steal should be during the rcv() callback to the user afaiu.
To view, visit change 34144. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3a279b55a3adff96948120683c844e1508d0ba94
Gerrit-Change-Number: 34144
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Tue, 22 Aug 2023 15:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment