Attention is currently required from: jolly.

Patch set 5:Code-Review +1

View Change

1 comment:

• File include/osmocom/gsm/gsm0808.h:

  • Patch Set #5, Line 386: struct sockaddr_storage *aoip_transport_layer;

    It is the same way it was done in "struct gsm0808_handover_request". […]

    You could add osmocom/core/socket.h and use "struct osmo_sockaddr" instead, which would be more handy for users too. And if there's a header problem on some systems in osmocom/core/socket.h it should be fixed.
    But anyway, not willing to block you despite I see using a pointer here as messy.

To view, visit change 32932. To unsubscribe, or for help writing mail filters, visit settings.