Attention is currently required from: pespin, fixeria.

Patch set 4:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #4:

    LGTM besides the uninitialized rc case that fixeria commented about

• File src/osmo-bts-sysmo/oml.c:

  • Patch Set #3, Line 1726: case NM_MT_SET_RADIO_ATTR:

    `rc` is uninitialized in this case. I suggest removing it and simply doing `return 0` below.

    (this is still unresolved)

To view, visit change 32196. To unsubscribe, or for help writing mail filters, visit settings.