Attention is currently required from: Hoernchen, osmith.
5 comments:
Patchset:
... except t
File ccid_common/ccid_proto.c:
Patch Set #1, Line 70: { CCID_ERR_CMD_ABORTED, "CMD_ABORTED" },
for the record, I don't think this is an improvement in readability at all.
File ccid_common/iso7816_fsm.c:
Patch Set #1, Line 168: static const uint8_t convention_convert_lut[256] = {
Formating this is wrong.
yeah, that looks like it's not intended.
Patch Set #1, Line 818: .in_event_mask = S(ISO7816_E_RX_SINGLE) | S(ISO7816_E_RX_COMPL) | S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_TX_ERR_IND) | S(ISO7816_E_TPDU_DONE_IND),
I also don't consider this an improvement inreadability; it also goes far beyond the 120 chasr / line limit. Maybe the linter rules are not good enough yet?
File sysmoOCTSIM/usb_descriptors.c:
this also clearly is not an improvement of readability at all.
To view, visit change 42330. To unsubscribe, or for help writing mail filters, visit settings.