Attention is currently required from: jolly, laforge, fixeria, dexter.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #8, Line 1244: static bool rtppayload_is_valid(struct gsm_lchan *lchan, struct msgb *resp_msg)

    if this is expected to be used only for incoming DL packets we forward to lower layers towards the MS, we should really make this function name more descriptive. Because with current name it really looks like it could be used in any direction.

  • Patch Set #8, Line 1274: /* BTS flags specify that RFC 5993 (and not ETSI TS 101.318) is understood by lower layers */

    All this code block below you are writing can iiuc be simplified to:

     if (resp_msg->len == GSM_HR_BYTES_RTP_RFC5993)
         return rfc5993;
     if (resp_msg->len == GSM_HR_BYTES_RTP_TS101318)
         return ts101318;
     return false;

  • Patch Set #8, Line 1952: * formats are supported (either by setting both or none of the flags), no conversion will be carried out. */

    we don't care about "both formats being supported". We care about the received format being supported.

    BTW, what's the point of checking the supported formats in rtppayload_is_valid() if we are anyway converting them here to whatever the supported format is? What am I missing?

To view, visit change 31417. To unsubscribe, or for help writing mail filters, visit settings.